Thread (20 messages) 20 messages, 3 authors, 2017-03-08

Re: [PATCH 02/11] block: Fix race of bdev open with gendisk shutdown

From: Tejun Heo <tj@kernel.org>
Date: 2017-03-07 19:43:49

Hello,

On Tue, Mar 07, 2017 at 12:14:20PM +0100, Jan Kara wrote:
quoted
Given that this isn't a super hot path, I think it'd be far better to
stick to a simpler synchronization mechanism.
I'd be happy to do so however struct gendisk does not have any lock in it
and introducing a special lock just for that seems awkward.
I think even a awkward shared lock is better than memory barriers.
Barriers are the trickiest locking construct to get right and we
really shouldn't using that unless absolutely necessary.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help