Re: [PATCH 2/2] block: fix leak of q->rq_wb
From: Omar Sandoval <osandov@osandov.com>
Date: 2017-03-28 02:53:06
On Mon, Mar 27, 2017 at 10:43:59AM -0700, Omar Sandoval wrote:
From: Omar Sandoval <redacted> CONFIG_DEBUG_TEST_DRIVER_REMOVE found a possible leak of q->rq_wb in a couple of cases: when a request queue is reregistered and when gendisks share a request_queue. This has been a problem since wbt was introduced, but the WARN_ON(!list_empty(&stats->callbacks)) in the blk-stat rework exposed it. The fix is unfortunately a hack until we fix all of the drivers sharing a request_queue.
FYI, I went through the remaining cases and fixed most of them up, working on the remaining few. Maybe we can finally put this crap to rest...