Thread (4 messages) 4 messages, 4 authors, 2017-03-29

Re: [PATCH] block-mq: don't re-queue if we get a queue error

From: Jens Axboe <axboe@kernel.dk>
Date: 2017-03-29 19:19:25

On 03/28/2017 02:37 PM, Josef Bacik wrote:
When try to issue a request directly and we fail we will requeue the
request, but call blk_mq_end_request() as well.  This leads to the
completed request being on a queuelist and getting ended twice, which
causes list corruption in schedulers and other shenanigans.
I think this is purely a cosmetic issue, as it should cause no
corruption. But it doesn't make sense to issue a requeue trace,
for instance, if we're just going to end the IO anyway. I have
applied it for 4.12.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help