On Thu 09-02-17 12:52:47, Thiago Jung Bauermann wrote:

Hello Jan,

Am Donnerstag, 9. Februar 2017, 13:44:23 BRST schrieb Jan Kara:

quoted

People, please have a look at patches. The are mostly simple however the
interactions are rather complex so I may have missed something. Also I'm
happy for any additional testing these patches can get - I've stressed them
with Omar's script, tested memcg writeback, tested static (not udev managed)
device inodes.

Thank you for these fixes. I will have them tested and report back how it 
goes.

Can you tell which branch I should apply them on? I tried a number of branches 
in linux-block (and applied the bdi lifetime v3 patches if the branch didn't 
already had them) but this series either didn't apply or the build failed 
with:

/home/bauermann/trabalho/src/linux-2.6.git/fs/block_dev.c: In function 
‘bd_acquire’:
/home/bauermann/trabalho/src/linux-2.6.git/fs/block_dev.c:1063:13: error: 
passing argument 1 of ‘bd_forget’ from incompatible pointer type [-
Werror=incompatible-pointer-types]
   bd_forget(bdev);
             ^
In file included from /home/bauermann/trabalho/src/linux-2.6.git/include/
linux/device_cgroup.h:1:0,
                 from /home/bauermann/trabalho/src/linux-2.6.git/fs/
block_dev.c:14:
/home/bauermann/trabalho/src/linux-2.6.git/include/linux/fs.h:2351:13: note: 
expected ‘struct inode *’ but argument is of type ‘struct block_device *’
 extern void bd_forget(struct inode *inode);
             ^
cc1: some warnings being treated as errors

Indeed, I'm wondering how this could pass one of the tests I did... Hum.
Anyway thanks for spotting this and attached is a fixed up version of the
patch 3.

I've pushed out a branch with all BDI patches I have accumulated to

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdi

It includes filesystem-bdi cleanup patches as well on top of these fixes.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR