Re: sense handling improvements
From: Hannes Reinecke <hare@suse.de>
Date: 2017-02-15 08:19:20
Also in:
linux-scsi
On 02/14/2017 08:15 PM, Christoph Hellwig wrote:
Hi all, this series is on top of the scsi_request changes in Jens' tree and further improves the handling of the sense buffer.
Sorry, but I'm feeling really daft: which scsi_request changes? To be found in which tree? I dimly remember seeing them, but have been unable to find them again.
The first patch prevents any possibily of reusing stale sense codes in sense headers, and is a bug fix that we should probably get into the block tree ASAP. The rest cleans up handling of the parsed sense data and could go in either through the block tree, or a SCSI branch on top of the block tree.
Have we audited all drivers to _not_ do DMA into the sense buffer? By first glance some still do, so they'll break horribly when moving the sense buffer onto the stack ... Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N�rnberg)