quoted
quoted
quoted
quoted
"Ilya" == Ilya Dryomov [off-list ref] writes:
Ilya,
Ilya> Well, blk_integrity_revalidate() doesn't clear the profile, it
Ilya> just clears the stable pages flag. Whoever calls
Ilya> blk_integrity_unregister() to clear the profile can also clear the
Ilya> stable pages flag -- why not let blk_integrity_unregister() clear
Ilya> the flag like I suggested?
That's what it used to do.
blk_integrity_revalidate() was obviously introduced to overcome some
problem. Unfortunately, I can't recall what that was and Google isn't
being particularly helpful. I suspect it was either in the NVDIMM or
NVMe camps since that's where the churn was.
I don't have a problem with your patch as long as we're sure there are
no regressions. I would carry the gendisk check over, though.
--
Martin K. Petersen Oracle Linux Engineering