Re: [PATCH 2/5] blk-mq: fix potential race in queue restart and driver tag allocation
From: Omar Sandoval <osandov@osandov.com>
Date: 2017-01-26 20:05:25
From: Omar Sandoval <osandov@osandov.com>
Date: 2017-01-26 20:05:25
On Thu, Jan 26, 2017 at 12:52:15PM -0700, Jens Axboe wrote:
I screwed this up when splitting up the patchset, that last break needs to be removed as well, of course. Updated below: From 9d68cf9232c06a793e305d10b6d655df4beae928 Mon Sep 17 00:00:00 2001 From: Jens Axboe <axboe@fb.com> Date: Thu, 26 Jan 2017 12:50:36 -0700 Subject: [PATCH 1/4] blk-mq: fix potential race in queue restart and driver tag allocation Once we mark the queue as needing a restart, re-check if we can get a driver tag. This fixes a theoretical issue where the needed IO completes _after_ blk_mq_get_driver_tag() fails, but before we manage to set the restart bit.
Reviewed-by: Omar Sandoval <redacted>
Signed-off-by: Jens Axboe <axboe@fb.com> --- block/blk-mq.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)