Re: [PATCH 14/18] scsi: remove __scsi_alloc_queue

From
Bart Van Assche <hidden>
Date
2017-01-27 17:58:02
Also in
dm-devel, linux-raid, linux-scsi
Reply to
Christoph Hellwig, 2017-01-25
On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.=
h
quoted hunk ↗ jump to hunk
index 8129239..b6e07b5 100644
--- a/include/scsi/scsi_transport.h
+++ b/include/scsi/scsi_transport.h
@@ -119,4 +119,6 @@ scsi_transport_device_data(struct scsi_device *sdev)
 		+ shost->transportt->device_private_offset;
 }
=20
+void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)=
;
+
 #endif /* SCSI_TRANSPORT_H */
Hello Christoph,

Since __scsi_init_queue() modifies data in the Scsi_Host structure, have yo=
u
considered to add the declaration for this function to <scsi/scsi_host.h>?
If you want to keep this declaration in <scsi/scsi_transport.h> please add =
a
direct include of that header file to drivers/scsi/scsi_lib.c such that the
declaration remains visible to the compiler if someone would minimize the
number of #include directives in SCSI header files.

Thanks,

Bart.=
Thread (97 messages) 97 messages, 6 authors, last reply 2017-02-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help