Thread (62 messages) 62 messages, 8 authors, 2017-01-16

Re: [PATCH 07/10] blk-mq: abstract out helpers for allocating/freeing tag maps

From: Bart Van Assche <hidden>
Date: 2017-01-12 21:29:11
Also in: lkml

On Wed, 2017-01-11 at 14:40 -0700, Jens Axboe wrote:
quoted hunk ↗ jump to hunk
@@ -2392,12 +2425,12 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *s=
et)
 	if (set->nr_hw_queues > nr_cpu_ids)
 		set->nr_hw_queues =3D nr_cpu_ids;
=20
+	ret =3D -ENOMEM;
 	set->tags =3D kzalloc_node(nr_cpu_ids * sizeof(struct blk_mq_tags *),
 				 GFP_KERNEL, set->numa_node);
 	if (!set->tags)
 		return -ENOMEM;
=20
-	ret =3D -ENOMEM;
 	set->mq_map =3D kzalloc_node(sizeof(*set->mq_map) * nr_cpu_ids,
 			GFP_KERNEL, set->numa_node);
 	if (!set->mq_map)
Not that it matters to me, but this change probably isn't needed?

Anyway:

Reviewed-by: Bart Van Assche <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help