Thread (4 messages) flat view 4 messages, 4 authors, 2017-01-09

Re: [PATCH] do_direct_IO: Use inode->i_blkbits to compute block count to be cleaned

From: Jens Axboe <axboe@kernel.dk>
Date: 2017-01-09 15:32:57
Also in: linux-fsdevel, linuxppc-dev, lkml

On 01/08/2017 07:47 AM, Chandan Rajendra wrote:
The code currently uses sdio->blkbits to compute the number of blocks to
be cleaned. However sdio->blkbits is derived from the logical block size
of the underlying block device (Refer to the definition of
do_blockdev_direct_IO()). Due to this, generic/299 test would rarely
fail when executed on an ext4 filesystem with 64k as the block size and
when using a virtio based disk (having 512 byte as the logical block
size) inside a kvm guest.

This commit fixes the bug by using inode->i_blkbits to compute the
number of blocks to be cleaned.
Thanks, added for 4.10.

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help