Re: [PATCH v2 16/16] block: unexport bsg_softirq_done() again
From: Hannes Reinecke <hare@suse.de>
Date: 2016-10-13 13:03:55
Also in:
linux-scsi, lkml
On 10/12/2016 03:06 PM, Johannes Thumshirn wrote:
quoted hunk ↗ jump to hunk
Unexport bsg_softirq_done() again, we don't need it outside of bsg-lib.c anymore now that scsi_transport_fc is a pure bsg-lib client. Signed-off-by: Johannes Thumshirn <redacted> --- block/bsg-lib.c | 3 +-- include/linux/bsg-lib.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-)diff --git a/block/bsg-lib.c b/block/bsg-lib.c index 46a4fee..4ac0ade 100644 --- a/block/bsg-lib.c +++ b/block/bsg-lib.c@@ -93,14 +93,13 @@ EXPORT_SYMBOL_GPL(bsg_job_done); * bsg_softirq_done - softirq done routine for destroying the bsg requests * @rq: BSG request that holds the job to be destroyed */ -void bsg_softirq_done(struct request *rq) +static void bsg_softirq_done(struct request *rq) { struct bsg_job *job = rq->special; blk_end_request_all(rq, rq->errors); bsg_job_put(job); } -EXPORT_SYMBOL_GPL(bsg_softirq_done); static int bsg_map_buffer(struct bsg_buffer *buf, struct request *req) {diff --git a/include/linux/bsg-lib.h b/include/linux/bsg-lib.h index b708db9..657a718 100644 --- a/include/linux/bsg-lib.h +++ b/include/linux/bsg-lib.h@@ -69,7 +69,6 @@ void bsg_job_done(struct bsg_job *job, int result, int bsg_setup_queue(struct device *dev, struct request_queue *q, char *name, bsg_job_fn *job_fn, int dd_job_size); void bsg_request_fn(struct request_queue *q); -void bsg_softirq_done(struct request *rq); void bsg_job_put(struct bsg_job *job); int __must_check bsg_job_get(struct bsg_job *job);
Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N�rnberg)