Thread (9 messages) 9 messages, 4 authors, 2016-11-02

Re: [PATCH 45/60] block: bio: introduce bio_for_each_segment_all_rd() and its write pair

From: Theodore Ts'o <tytso@mit.edu>
Date: 2016-10-31 14:00:07
Also in: linux-fsdevel, lkml

On Sat, Oct 29, 2016 at 04:08:44PM +0800, Ming Lei wrote:
This patches introduce bio_for_each_segment_all_rd() and
bio_for_each_segment_all_wt().

bio_for_each_segment_all_rd() is for replacing
bio_for_each_segment_all() in case the bvec from bio->bi_io_vec
is accessed as readonly.

bio_for_each_segment_all_wt() is for replacing
bio_for_each_segment_all() in case the bvec from bio->bi_io_vec
need to be updated.
What is _rd and _wt supposed to stand for?  And speaking more
generally, could you write up some more detailed notes about all of
the various new functions they have been added, when they should be
used, and some kind of roadmap about how things are supposed to work
beyond the very high-level description in the introduction in your
patch series?  Ideally it would go into the Documentation directory,
so that after this patch set gets applied, people will be able to
refer to it to understand how things are supposed to work.

Thanks!!

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help