Thread (4 messages) 4 messages, 3 authors, 2016-10-31

Re: [PATCH 26/60] btrfs: set NO_MP for request queues behind BTRFS

From: Chris Mason <clm@fb.com>
Date: 2016-10-31 18:00:35
Also in: linux-btrfs, linux-fsdevel, lkml

On Mon, Oct 31, 2016 at 08:36:44AM -0700, Christoph Hellwig wrote:
On Sat, Oct 29, 2016 at 04:08:25PM +0800, Ming Lei wrote:
quoted
There are lots of direct access to .bi_vcnt & .bi_io_vec
of bio, and it isn't ready to support multipage bvecs
for BTRFS, so set NO_MP for these request queues.
For one bio is an I/O submitter, it has absolutely no business changing
queue flags - if we need to stick to this limitation it simply needs
a version of bio_add_page that doesn't create multi-page bvecs.

Second I don't think making it multipage bvec aware is all that hard,
and we should aim for doing the proper thing.
Yeah, I'd rather make us less special.  The direct access was a short 
term fix to adjust to the new bio interfaces, we should clean it up.

-chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help