Thread (7 messages) 7 messages, 4 authors, 2016-11-02

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

From: Ming Lei <tom.leiming@gmail.com>
Date: 2016-10-31 22:59:54
Also in: dm-devel, linux-fsdevel, linux-raid, lkml

On Mon, Oct 31, 2016 at 11:29 PM, Christoph Hellwig [off-list ref] wrote:
On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote:
quoted
Avoid to access .bi_vcnt directly, because it may be not what
the driver expected any more after supporting multipage bvec.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
It would be really nice to have a comment in the code why it's
even checking for multiple segments.
OK, will add comment about using !bio_multiple_segments(rq->bio)
to replace 'rq->bio->bi_vcnt == 1'.


Thanks,
Ming Lei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help