Thread (31 messages) 31 messages, 8 authors, 2016-10-11

Re: [PATCH 2/9] dm: Fix a race condition related to stopping and starting queues

From: Johannes Thumshirn <hidden>
Date: 2016-09-27 07:47:36
Also in: linux-nvme, linux-rdma, linux-scsi

On Mon, Sep 26, 2016 at 11:26:50AM -0700, Bart Van Assche wrote:
Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request()
calls have stopped before setting the "queue stopped" flag. This
allows to remove the "queue stopped" test from dm_mq_queue_rq() and
dm_mq_requeue_request(). This patch fixes a race condition because
dm_mq_queue_rq() is called without holding the queue lock and hence
BLK_MQ_S_STOPPED can be set at any time while dm_mq_queue_rq() is
in progress.

Signed-off-by: Bart Van Assche <redacted>
Cc: Mike Snitzer <redacted>
---
Looks good,
Reviewed-by: Johannes Thumshirn <redacted>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help