Thread (18 messages) 18 messages, 5 authors, 2016-09-27

Re: [PATCH v2 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

From: Shaun Tancheff <hidden>
Date: 2016-09-27 21:10:23
Also in: linux-scsi

On Mon, Sep 26, 2016 at 6:14 AM, Damien Le Moal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Hannes Reinecke <hare@suse.de>

The queue limits already have a 'chunk_sectors' setting, so
we should be presenting it via sysfs.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Damien Le Moal <redacted>
---
 block/blk-sysfs.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index ff9cd9c..488c2e2 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -130,6 +130,11 @@ static ssize_t queue_physical_block_size_show(struct request_queue *q, char *pag
        return queue_var_show(queue_physical_block_size(q), page);
 }

+static ssize_t queue_chunk_sectors_show(struct request_queue *q, char *page)
+{
+       return queue_var_show(q->limits.chunk_sectors, page);
+}
+
 static ssize_t queue_io_min_show(struct request_queue *q, char *page)
 {
        return queue_var_show(queue_io_min(q), page);
@@ -455,6 +460,11 @@ static struct queue_sysfs_entry queue_physical_block_size_entry = {
        .show = queue_physical_block_size_show,
 };

+static struct queue_sysfs_entry queue_chunk_sectors_entry = {
+       .attr = {.name = "chunk_sectors", .mode = S_IRUGO },
+       .show = queue_chunk_sectors_show,
+};
+
 static struct queue_sysfs_entry queue_io_min_entry = {
        .attr = {.name = "minimum_io_size", .mode = S_IRUGO },
        .show = queue_io_min_show,
@@ -555,6 +565,7 @@ static struct attribute *default_attrs[] = {
        &queue_hw_sector_size_entry.attr,
        &queue_logical_block_size_entry.attr,
        &queue_physical_block_size_entry.attr,
+       &queue_chunk_sectors_entry.attr,
        &queue_io_min_entry.attr,
        &queue_io_opt_entry.attr,
        &queue_discard_granularity_entry.attr,
--
2.7.4
Reviewed-by: Shaun Tancheff <redacted>
Tested-by: Shaun Tancheff <redacted>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Shaun Tancheff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help