Thread (33 messages) 33 messages, 7 authors, 2016-09-26

Re: [PATCH 01/13] genirq/msi: Add cpumask allocation to alloc_msi_entry

flat view

From: Christoph Hellwig <hch@lst.de>
Date: 2016-09-19 13:50:17
Also in: lkml

On Mon, Sep 19, 2016 at 09:30:58AM +0200, Alexander Gordeev wrote:
quoted
 	INIT_LIST_HEAD(&desc->list);
 	desc->dev = dev;
+	desc->nvec_used = nvec;
+	if (affinity) {
+		desc->affinity = kmemdup(affinity,
+			nvec * sizeof(*desc->affinity), GFP_KERNEL);
+		if (!desc->affinity) {
+			kfree(desc);
+			return NULL;
+		}
+	}
nit - should not "desc" initialization follow "desc->affinity" allocation?
I can't parse that sentence.  Do you mean the desc->nvec_used setup?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help