Thread (15 messages) 15 messages, 3 authors, 2016-09-01

Re: [PATCH 7/8] wbt: add general throttling mechanism

From: Jens Axboe <axboe@fb.com>
Date: 2016-09-01 21:00:59
Also in: linux-fsdevel, lkml

On 09/01/2016 12:05 PM, Omar Sandoval wrote:
quoted
diff --git a/lib/Kconfig b/lib/Kconfig
index d79909dc01ec..5a65a1f91889 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -550,4 +550,8 @@ config STACKDEPOT
 	bool
 	select STACKTRACE

+config WBT
+	bool
+	select SCALE_BITMAP
Looks like this snuck in from your experiments to get this to work on
top of scale_bitmap?
Oops yes, it is indeed. Killed, thanks.
quoted
+	if (waitqueue_active(&rwb->wait)) {
+		int diff = limit - inflight;
+
+		if (!inflight || diff >= rwb->wb_background / 2)
+			wake_up_nr(&rwb->wait, 1);
wake_up(&rwb->wait)?
Yeah, that'd be cleaner. I think this is a leftover from when I 
experimented with batched wakeups, with nr != 1. I'll change it to just 
wake_up().

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help