On 09/01/16 17:51, Joe Perches wrote:=0A=

On Fri, 2016-09-02 at 00:47 +0000, Bart Van Assche wrote:=0A=

quoted

On 09/01/16 13:11, Joe Perches wrote:=0A=

quoted

=0A=
Assigning an int to a bitfield:1 can lose precision.=0A=
Change the caller argument uses from 1/0 to true/false.=0A=

Hello Joe,=0A=

=0A=
Hi Bart.=0A=
=0A=

quoted

Can you clarify how assigning 0 or 1 to a one-bit bitfield can cause a=

=0A=

quoted

loss of precision?=0A=

=0A=
There are no existing defects.=0A=
=0A=
Using 1/0 is not a loss of precision, it's just=0A=
changing to use bool avoids potential errors and=0A=
promotes consistency.=0A=
=0A=
Other uses of this function already use true/false.=0A=

=0A=
Hello Joe,=0A=
=0A=
In the patch description you refer to loss of precision. However, your =0A=
patch does not address any loss of precision issues. So I think that the =
=0A=
patch description is misleading and could be made more clear.=0A=
=0A=
Bart.=0A=