Re: [PATCH 1/1] blk-mq: fix hang caused by freeze/unfreeze sequence
From: kbuild test robot <hidden>
Date: 2016-08-05 18:05:54
Also in:
lkml
Hi Roman, [auto build test ERROR on block/for-next] [also build test ERROR on v4.7 next-20160805] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Roman-Pen/blk-mq-fix-hang-caused-by-freeze-unfreeze-sequence/20160806-014441 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: x86_64-randconfig-x015-201631 (attached as .config) compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings (new ones prefixed by >>): In file included from include/linux/mmzone.h:9:0, from include/linux/gfp.h:5, from include/linux/kmod.h:22, from include/linux/module.h:13, from block/blk-core.c:15: block/blk-core.c: In function 'blk_queue_enter':
quoted
block/blk-core.c:661:18: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
!atomic_read(&q->mq_freeze_depth) ||
^
include/linux/wait.h:473:8: note: in definition of macro 'wait_event_interruptible'
if (!(condition)) \
^~~~~~~~~
In file included from arch/x86/include/asm/msr.h:66:0,
from arch/x86/include/asm/processor.h:20,
from arch/x86/include/asm/cpufeature.h:4,
from arch/x86/include/asm/thread_info.h:52,
from include/linux/thread_info.h:54,
from arch/x86/include/asm/preempt.h:6,
from include/linux/preempt.h:59,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from block/blk-core.c:15:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'int *'
static __always_inline int atomic_read(const atomic_t *v)
^~~~~~~~~~~
In file included from include/linux/mmzone.h:9:0,
from include/linux/gfp.h:5,
from include/linux/kmod.h:22,
from include/linux/module.h:13,
from block/blk-core.c:15:quoted
block/blk-core.c:661:18: error: passing argument 1 of 'atomic_read' from incompatible pointer type [-Werror=incompatible-pointer-types]
!atomic_read(&q->mq_freeze_depth) ||
^
include/linux/wait.h:278:7: note: in definition of macro '___wait_event'
if (condition) \
^~~~~~~~~
include/linux/wait.h:474:11: note: in expansion of macro '__wait_event_interruptible'
__ret = __wait_event_interruptible(wq, condition); \
^~~~~~~~~~~~~~~~~~~~~~~~~~quoted
block/blk-core.c:660:9: note: in expansion of macro 'wait_event_interruptible'
ret = wait_event_interruptible(q->mq_freeze_wq,
^~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/msr.h:66:0,
from arch/x86/include/asm/processor.h:20,
from arch/x86/include/asm/cpufeature.h:4,
from arch/x86/include/asm/thread_info.h:52,
from include/linux/thread_info.h:54,
from arch/x86/include/asm/preempt.h:6,
from include/linux/preempt.h:59,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/linux/stat.h:18,
from include/linux/module.h:10,
from block/blk-core.c:15:
arch/x86/include/asm/atomic.h:24:28: note: expected 'const atomic_t * {aka const struct <anonymous> *}' but argument is of type 'int *'
static __always_inline int atomic_read(const atomic_t *v)
^~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/atomic_read +661 block/blk-core.c
3ef28e83 Dan Williams 2015-10-21 654 if (percpu_ref_tryget_live(&q->q_usage_counter))
3ef28e83 Dan Williams 2015-10-21 655 return 0;
3ef28e83 Dan Williams 2015-10-21 656
6f3b0e8b Christoph Hellwig 2015-11-26 657 if (nowait)
3ef28e83 Dan Williams 2015-10-21 658 return -EBUSY;
3ef28e83 Dan Williams 2015-10-21 659
3ef28e83 Dan Williams 2015-10-21 @660 ret = wait_event_interruptible(q->mq_freeze_wq,
3ef28e83 Dan Williams 2015-10-21 @661 !atomic_read(&q->mq_freeze_depth) ||
3ef28e83 Dan Williams 2015-10-21 662 blk_queue_dying(q));
3ef28e83 Dan Williams 2015-10-21 663 if (blk_queue_dying(q))
3ef28e83 Dan Williams 2015-10-21 664 return -ENODEV;
:::::: The code at line 661 was first introduced by commit
:::::: 3ef28e83ab15799742e55fd13243a5f678b04242 block: generic request_queue reference counting
:::::: TO: Dan Williams [off-list ref]
:::::: CC: Jens Axboe [off-list ref]
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/octet-stream] 27324 bytes