Re: Fixup direct bi_rw modifiers

From
Jens Axboe <axboe@kernel.dk>
Date
2016-08-01 19:55:48
Also in
linux-btrfs, lkml
Reply to
Jens Axboe, 2016-08-01
On 08/01/2016 09:17 AM, Jens Axboe wrote:
On 08/01/2016 05:47 AM, Christoph Hellwig wrote:
quoted
On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote:
quoted
bi_rw should be using bio_set_op_attrs to set bi_rw.
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Added, thanks Shaun.
quoted
Jens,

what do you think about renaming bi_rw?  There aren't too many users
left, and any old code that would keep using it is alsmost guranteed
to be broken, so sending a post-rc1 patch to rename it might make
everyone else life easier.  Especially as it's also grossly misnamed
now.
I was planning on doing that, after -rc1. Much better to get build
breakage, than potentially much worse breakage.
Set of three patches, where the target one is an actual bug fix...
Temporary branch, I'll rebase it once -rc1 is out, if more
changes/fixups need to be made in the next week until that happens.

http://git.kernel.dk/cgit/linux-block/log/?h=for-4.8/bi_rwf

-- 
Jens Axboe
Thread (6 messages) 6 messages, 3 authors, last reply 2016-08-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help