Re: Question about loop device DIO/AIO and FLUSH

From
Ming Lei <hidden>
Date
2016-07-01 06:57:47
Also in
linux-fsdevel
Reply to
Amir Goldstein, 2016-06-30
On Fri, Jul 1, 2016 at 4:54 AM, Amir Goldstein [off-list ref] wrote:
Hi Ming,

I was reading through the code of loop DIO/AIO
and I was wondering whether lo_req_flush() really
honors REQ_FLUSH by calling  vfs_fsync() on a backing file
that is open with O_DIRECT?
From view of device, REQ_FLUSH just flushs the cache inside
drive to medium.

Shouldn't lo_req_flush() actually wait for completion of
all the in-flight loop AIO requests to complete?
I think it isn't needed, just like the flush handling in blk-flush.c, and
it just works for completed I/O.

Am I missing something?

Thanks,
Amir.
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  






  

    
      Thread (9 messages)
      
        9 messages,
        4 authors,
        last reply 2016-07-03
      
    
    
      
      
      
    
  

  

  
  




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help