On Thu, Jun 9, 2016 at 7:10 AM, Christoph Hellwig [off-list ref] wrote:

On Thu, Jun 09, 2016 at 02:19:55PM +0300, Sagi Grimberg wrote:

quoted

This needs documentation in the form of:

/*
 * XXX: blk-mq might not map all our hw contexts but this is a must for
 * us for fabric connects. So until we can fix blk-mq we check that.
 */

I think the right thing to do is to have a member of actually mapped
queues in the block layer, and I also don't think we need the XXX comment
as there are valid reasons for not mapping all queues.

I think it is a rare case that we need all hw contexts mapped.
Seems unnecessary to add a new field to "struct request_queue" for the
rare case.