Thread (2 messages) 2 messages, 2 authors, 2016-06-09

Re: [PATCH] blk-mq: actually hook up defer list when running requests

From: Jens Axboe <axboe@fb.com>
Date: 2016-06-09 15:55:06

On 06/08/2016 07:22 PM, Omar Sandoval wrote:
From: Omar Sandoval <redacted>

If ->queue_rq() returns BLK_MQ_RQ_QUEUE_OK, we use continue and skip
over the rest of the loop body. However, dptr is assigned later in the
loop body, and the BLK_MQ_RQ_QUEUE_OK case is exactly the case that we'd
want it for.

NVMe isn't actually using BLK_MQ_F_DEFER_ISSUE yet, nor is any other
in-tree driver, but if the code's going to be there, it might as well
work.

Fixes: 74c450521dd8 ("blk-mq: add a 'list' parameter to ->queue_rq()")
Signed-off-by: Omar Sandoval <redacted>
Thanks Omar, good catch!

-- 
Jens Axboe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help