Re: [PATCH] blktrace: avoid using timespec
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-06-18 19:01:38
Also in:
lkml
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-06-18 19:01:38
Also in:
lkml
On Friday, June 17, 2016 5:54:16 PM CEST Jeff Moyer wrote:
Jens Axboe [off-list ref] writes:quoted
On 06/17/2016 05:36 PM, Steven Rostedt wrote:quoted
Jens, You want to take this, or do you want me to?I'll add it to my 4.8 tree, thanks Arnd.+ /* need to check user space to see if this breaks in y2038 or y2106 */ Userspace just uses it to print the timestamp, right? So do we need the comment?
If we have more details, the comment should describe what happens and when it overflows. If you have the source at hand, maybe you can answer these: How does it print the timestamp? Does it print the raw seconds value using %u (correct) or %d (incorrect), or does it convert it into year/month/day/hour/min/sec? In the last case, how does it treat second values above 0x80000000? Are those printed as year 2038 or year 1902? Are we sure that there is only one user space implementation that reads these values? Arnd