Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled
From: Shaohua Li <hidden>
Date: 2016-05-11 00:20:18
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2016-05-11 · Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled · Shaohua Li <hidden>
- 2016-05-11 · Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled · Shaohua Li <hidden>
- 2016-05-11 · Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled · Jeff Moyer <hidden>
- 2016-05-11 · Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled · Jeff Moyer <hidden>
- 2016-05-11 · Re: [PATCH 3/3] blk-throttle: don't parse cgroup path if trace isn't enabled · Simon Guo <hidden>
On Tue, May 10, 2016 at 11:52:15AM -0400, Jeff Moyer wrote:
Shaohua Li [off-list ref] writes:quoted
if trace isn't enabled, parsing cgroup path just wastes cpu Signed-off-by: Shaohua Li <redacted> --- block/blk-throttle.c | 5 ++--- include/linux/blktrace_api.h | 9 +++++++++ 2 files changed, 11 insertions(+), 3 deletions(-)diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 2149a1d..47a3e54 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c@@ -211,15 +211,14 @@ static struct throtl_data *sq_to_td(struct throtl_service_queue *sq) * * The messages are prefixed with "throtl BLKG_NAME" if @sq belongs to a * throtl_grp; otherwise, just "throtl". - * - * TODO: this should be made a function and name formatting should happen - * after testing whether blktrace is enabled.You've only addressed the second part of the TODO, please don't remove the first part.
alright, I'll send a patch to convert it to a function.