Thread (22 messages) 22 messages, 7 authors, 2016-05-20

Re: [PATCH] remove unused blkdev_dax_capable() function

From: Toshi Kani <hidden>
Date: 2016-05-18 14:10:26
Also in: linux-fsdevel, lkml, nvdimm

On Wed, 2016-05-18 at 09:54 +0200, Arnd Bergmann wrote:
The change from blkdev_dax_capable() to bdev_dax_capable() removed the
only user of the former, so we now get a build warning:

fs/block_dev.c:1244:13: error: 'blkdev_dax_capable' defined but not used
[-Werror=unused-function]
 static bool blkdev_dax_capable(struct block_device *bdev)

This removes the now-unused function.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: a8078b1fc616 ("block: Update blkdev_dax_capable() for
consistency")
 :
It's not entirely from the patch description what the intention was here
in keeping two slightly different implementations of the same function
in one file, my best guess is that it was not intentional and we should
just remove this.
Thanks for the build fix.  Looks like there was a conflict
between 8044aae6f374 and a8078b1fc616d, which resulted this build error.
Both patches moved blkdev_dax_capable() from block/ioctl.c
to fs/block_dev.c.

Acked-by: Toshi Kani <redacted>

Thanks,
-Toshi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help