On Fri, Aug 09, 2024 at 02:44:24PM -0400, Josef Bacik wrote:

-	if (write_fault)
-		return xfs_write_fault(vmf, order);
+	if (write_fault) {
+		vm_fault_t ret = filemap_maybe_emit_fsnotify_event(vmf);
+		if (unlikely(ret))
+			return ret;
+		xfs_write_fault(vmf, order);

This now loses the return value from xfs_write_fault and falls through
to actually do the read fault as well.  I somehow doubt this can work
at all as-is.

Please also move the filemap_maybe_emit_fsnotify_event call into
xfs_write_fault to keep the write fault handling isolated there,
which is the reason that it exists.