Re: don't use ->bd_inode to access the block device size v3

From: Christoph Hellwig <hch@lst.de>
Date: 2021-10-18 17:49:11
Also in: dm-devel, linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-nfs, linux-nvme, linux-raid, linux-scsi, ntfs3, target-devel
Reply to: Jens Axboe, 2021-10-18

On Mon, Oct 18, 2021 at 11:40:51AM -0600, Jens Axboe wrote:

quoted hunk ↗ jump to hunk

 static inline loff_t bdev_nr_bytes(struct block_device *bdev)
 {
-	return i_size_read(bdev->bd_inode);
+	return bdev->bd_nr_sectors;

This hunk needs to go into bdev_nr_sectors, and the bdev_nr_bytes
probably wants to call bdev_nr_sectors and do the shifting.

Christoph Hellwig · 2021-10-18
[PATCH 02/30] block: add a bdev_nr_bytes helper · Christoph Hellwig · 2021-10-18
[PATCH 01/30] block: move the SECTOR_SIZE related definitions to blk_types.h · Christoph Hellwig · 2021-10-18
[PATCH 03/30] bcache: remove bdev_sectors · Christoph Hellwig · 2021-10-18
[PATCH 04/30] drbd: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 05/30] dm: use bdev_nr_sectors and bdev_nr_bytes instead of open coding them · Christoph Hellwig · 2021-10-18
[PATCH 07/30] nvmet: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 06/30] md: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 08/30] target/iblock: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 12/30] btrfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 10/30] fs: simplify init_page_buffers · Christoph Hellwig · 2021-10-18
[PATCH 11/30] affs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 13/30] cramfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 09/30] fs: use bdev_nr_bytes instead of open coding it in blkdev_max_block · Christoph Hellwig · 2021-10-18
[PATCH 14/30] fat: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 15/30] hfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 16/30] hfsplus: use bdev_nr_sectors instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 17/30] jfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 18/30] nfs/blocklayout: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 19/30] nilfs2: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 20/30] ntfs3: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 21/30] pstore/blk: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 23/30] squashfs: use bdev_nr_bytes instead of open coding it · Christoph Hellwig · 2021-10-18
[PATCH 24/30] block: use bdev_nr_bytes instead of open coding it in blkdev_fallocate · Christoph Hellwig · 2021-10-18
[PATCH 30/30] udf: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-18
[PATCH 29/30] reiserfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-18
[PATCH 28/30] ntfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-18
[PATCH 27/30] jfs: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-18
[PATCH 25/30] block: add a sb_bdev_nr_blocks helper · Christoph Hellwig · 2021-10-18
[PATCH 26/30] ext4: use sb_bdev_nr_blocks · Christoph Hellwig · 2021-10-18
Jens Axboe · 2021-10-18
Christoph Hellwig · 2021-10-18
Jens Axboe · 2021-10-18
Christoph Hellwig · 2021-10-18
Jens Axboe · 2021-10-18
Christoph Hellwig · 2021-10-18
Kari Argillander · 2021-10-19
Jens Axboe · 2021-10-19
Jens Axboe · 2021-10-18
View all 40 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help