Thread (2 messages) 2 messages, 2 authors, 2021-10-13

回复: [PATCH] bcache: replace snprintf in show functions with sysfs_emit

From: 王擎 <hidden>
Date: 2021-10-13 07:39:22
Also in: lkml

quoted
diff --git a/drivers/md/bcache/sysfs.h b/drivers/md/bcache/sysfs.h
index 215df32..8bec32d 100644
--- a/drivers/md/bcache/sysfs.h
+++ b/drivers/md/bcache/sysfs.h
@@ -51,7 +51,7 @@ STORE(fn)                                                           \
  #define sysfs_printf(file, fmt, ...)                                        \
  do {                                                                        \
       if (attr == &sysfs_ ## file)                                    \
-             return snprintf(buf, PAGE_SIZE, fmt "\n", __VA_ARGS__); \
+             return sysfs_emit(buf, fmt "\n", __VA_ARGS__);  \
  } while (0)
  
  #define sysfs_print(file, var)                                              \
IMHO I like this change :-) BTW, for snprint() from util.h, it seems 
only to be used by sysfs_print() in syfs.h, would you like to change it 
to use sysfs_emit too ?

Thanks for the patch.

Coly Li
sysfs_print() should also be modified if size is a fixed value PAGE_SIZE, 
but here is param, it would be appreciate if you have better method.

Thanks,

Qing
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help