Le mercredi 05 septembre 2018 à 19:33 +0200, Yann Droneaud a écrit :

Le mercredi 05 septembre 2018 à 18:55 +0200, Greg KH a écrit :

quoted

On Wed, Sep 05, 2018 at 04:54:27PM +0100, David Howells wrote:

quoted

Here's a set of patches that inserts a step into the build
process to make
sure that the UAPI headers can all be built together with C++ (if
the
compiler being used supports C++).  All but the final patch
perform fixups,
including:

Wait, why do we care?  What has recently changed to start to
directly
import kernel uapi files into C++ code?

And if userspace wants to do this, can't they do the C namespace
trick
themselves when they do the import?  That must be how they are
doing it
today, right?

They can't.


Adding extern "C" { } doesn't magically make "class" a non keyword.
Even if it was the case, writing C++ code using whatever->class would
probably broke because class is a keyword in C++.

For the record, libX11 has to handle the kink pf issue with C++
keyword:


https://gitlab.freedesktop.org/xorg/lib/libx11/blob/733f64bfeb311c1d040b2f751bfdef9c9d0f89ef/include/X11/Xlib.h#L227

typedef struct {
	XExtData *ext_data;	/* hook for extension to hang data */
	VisualID visualid;	/* visual id of this visual */
#if defined(__cplusplus) || defined(c_plusplus)
	int c_class;		/* C++ class of screen (monochrome, etc.) */
#else
	int class;		/* class of screen (monochrome, etc.) */
#endif
	unsigned long red_mask, green_mask, blue_mask;	/* mask values */
	int bits_per_rgb;	/* log base 2 of distinct color values */
	int map_entries;	/* color map entries */
} Visual;


Regards.

-- 
Yann Droneaud
OPTEYA


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm