Thread (4 messages) 4 messages, 3 authors, 2017-12-23

Re: [PATCH 01/11] block_dev: Support checking inode permissions in lookup_bdev()

From: Dongsu Park <hidden>
Date: 2017-12-23 12:00:57
Also in: dm-devel, linux-fsdevel, lkml

Hi,

On Fri, Dec 22, 2017 at 7:59 PM, Coly Li [off-list ref] wrote:
On 22/12/2017 10:32 PM, Dongsu Park wrote:
Hi Dongsu,

Could you please use a macro like NO_PERMISSION_CHECK to replace hard
coded 0 ? At least for me, I don't need to check what does 0 mean in the
new lookup_bdev().
I see. I'll do that.

Thanks,
Dongsu
Thanks.

Coly Li
quoted
---
 drivers/md/bcache/super.c |  2 +-
 drivers/md/dm-table.c     |  2 +-
 drivers/mtd/mtdsuper.c    |  2 +-
 fs/block_dev.c            | 13 ++++++++++---
 fs/quota/quota.c          |  2 +-
 include/linux/fs.h        |  2 +-
 6 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index b4d28928..acc9d56c 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1967,7 +1967,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr,
                                sb);
      if (IS_ERR(bdev)) {
              if (bdev == ERR_PTR(-EBUSY)) {
-                     bdev = lookup_bdev(strim(path));
+                     bdev = lookup_bdev(strim(path), 0);
                      mutex_lock(&bch_register_lock);
                      if (!IS_ERR(bdev) && bch_is_open(bdev))
                              err = "device already registered";
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 88130b5d..bca5eaf4 100644
[snip]


--
Coly Li
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help