Re: [PATCH 2/4] bcache: Fix building error on MIPS
From: Christoph Hellwig <hch@infradead.org>
Date: 2017-11-28 13:42:21
Also in:
linux-block, stable
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h index 90fc490f973f..821f71a2e48f 100644 --- a/include/uapi/linux/bcache.h +++ b/include/uapi/linux/bcache.h@@ -91,7 +91,7 @@ PTR_FIELD(PTR_GEN, 0, 8) #define PTR_CHECK_DEV ((1 << PTR_DEV_BITS) - 1) -#define PTR(gen, offset, dev) \ +#define MAKE_PTR(gen, offset, dev) \ ((((__u64) dev) << 51) | ((__u64) offset) << 8 | gen)
This really should have a BCACHE_ prefix, and probably a lower case name. And last but not least it really shouldn't be in a uapi header. Similar things apply to various other things around it.