Thread (7 messages) 7 messages, 3 authors, 2017-10-27

Re: [PATCHv4] bcache: only permit to recovery read error when cache device is clean

From: Eric Wheeler <hidden>
Date: 2017-10-27 21:13:59
Also in: stable

On Fri, 27 Oct 2017, Michael Lyle wrote:
On Fri, Oct 27, 2017 at 12:57 PM, Eric Wheeler
[off-list ref] wrote:
quoted
Can this be relaxed to only error when the key failing to read is dirty?
The liklihood of a 100% clean cache in writeback on a busy system seems
unlikely.

Can KEY_DIRTY facilitate this?
Don't we only have the metadata to know if the key is dirty on the
cache if we have the cache device? ;)
Certainly if this is for removal or a missing cache (perhaps I missed 
that).

However, I thought this was just a recovery on an IO error where the disk 
might be mostly dead--but partly alive!

Of course if the metadata lookup fails subsequently, then you would need 
to fall back to the dc->has_dirty flag.

--
Eric Wheeler


Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help