Thread (3 messages) 3 messages, 3 authors, 2017-10-30

Re: [PATCH] [PATCH V2] bcache: fix wrong cache_misses statistics

From: Michael Lyle <hidden>
Date: 2017-10-30 05:14:37
Also in: linux-block

On 10/27/2017 07:39 PM, tang.junhui@zte.com.cn wrote:
From: "tang.junhui" <redacted>

Currently, Cache missed IOs are identified by s->cache_miss, but actually,
there are many situations that missed IOs are not assigned a value for
s->cache_miss in cached_dev_cache_miss(), for example, a bypassed IO
(s->iop.bypass = 1), or the cache_bio allocate failed. In these situations,
it will go to out_put or out_submit, and s->cache_miss is null, which leads
bch_mark_cache_accounting() to treat this IO as a hit IO.

Signed-off-by: tang.junhui <redacted>
Reviewed-by: Michael Lyle <redacted>

Applied to my local tree for test.  Thanks!

-mpl
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help