Re: [PATCH 1/2] bcache: Remove redundant set_capacity
From: wangyijing <hidden>
Date: 2016-11-28 00:52:49
Also in:
lkml
From: wangyijing <hidden>
Date: 2016-11-28 00:52:49
Also in:
lkml
在 2016/11/27 15:57, Coly Li 写道:
On 2016/11/25 上午9:39, Yijing Wang wrote:quoted
set_capacity() has been called in bcache_device_init(), remove the redundant one. Signed-off-by: Yijing Wang <redacted> --- drivers/md/bcache/super.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 849ad44..b638a16 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c@@ -1126,9 +1126,6 @@ static int cached_dev_init(struct cached_dev *dc, unsigned block_size) if (ret) return ret; - set_capacity(dc->disk.disk, - dc->bdev->bd_part->nr_sects - dc->sb.data_offset); - dc->disk.disk->queue->backing_dev_info.ra_pages = max(dc->disk.disk->queue->backing_dev_info.ra_pages, q->backing_dev_info.ra_pages);Hi Yijing, Nice catch, it looks good to me. Acked-by: Coly Li <redacted>
Thanks!