Thread (5 messages) 5 messages, 2 authors, 2016-10-18

Re: [bcachefs][tier] INFO: task bch_tier_read:21414 blocked for more than 120 seconds.

From: Marcin Mirosław <hidden>
Date: 2016-10-18 06:07:36

W dniu 2016-10-18 o 02:30, Kent Overstreet pisze:
On Wed, Oct 12, 2016 at 09:51:17PM +0200, Marcin wrote:
quoted
W dniu 2016-10-12 21:19, Kent Overstreet napisał(a):
quoted
It needs to return true, not false.
It's not a bash, ok:)

With:
--- a/drivers/md/bcache/journal.h
+++ b/drivers/md/bcache/journal.h
@@ -184,7 +184,8 @@ static inline unsigned jset_u64s(unsigned u64s)

 static inline bool journal_flushes_device(struct cache *ca)
 {
-       return ca->mi.tier == 0;
+       /** return ca->mi.tier == 0; **/
+       return true;
Chris retested with the latest bcache-dev and it seems to be working for him
now - can you retest with bcache-dev too?

Hi!
I retested, I can't trigger this bug again. It looks you fixed this. Thanks!
I noticed that umounting filesystem gives me such messages:
[ 4460.050248] bch_write: 7 callbacks suppressed
[ 4460.050261] bcache (53f02c70-608f-48e9-bdb9-53132b44fce4): IO error: 
read only
[ 4460.240296] bcache (53f02c70-608f-48e9-bdb9-53132b44fce4): stopped

Is it something important?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help