Thread (8 messages) 8 messages, 3 authors, 2016-05-11

Re: [PATCH 3/3] bcache: Remove redundant block_size assignment

From: wangyijing <hidden>
Date: 2016-05-11 01:14:00


在 2016/5/10 22:51, Coly Li 写道:
在 16/5/10 下午4:38, Yijing Wang 写道:
quoted
Signed-off-by: Yijing Wang <redacted>
---
 drivers/md/bcache/super.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 1ccb9be..64d0be6 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -134,7 +134,6 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev,
 	case BCACHE_SB_VERSION_CDEV:
 	case BCACHE_SB_VERSION_CDEV_WITH_UUID:
 		sb->nbuckets	= le64_to_cpu(s->nbuckets);
-		sb->block_size	= le16_to_cpu(s->block_size);
 		sb->bucket_size	= le16_to_cpu(s->bucket_size);
 
 		sb->nr_in_set	= le16_to_cpu(s->nr_in_set);
Yes, this assignment is redundant. Could you please to add some comments
to describe this patch before your Signed-off-by ? This will be
informative and helpful for others who may back port the patches.
OK.

Thanks!
Yijing.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help