Thread (8 messages) 8 messages, 3 authors, 2016-05-25
STALE3704d

[PATCH 3/4] bcache: bch_gc_thread() is not freezable

From: Jiri Kosina <jikos@kernel.org>
Date: 2016-05-24 14:38:35
Also in: lkml
Subsystem: bcache (block layer cache), the rest · Maintainers: Coly Li, Kent Overstreet, Linus Torvalds

From: Jiri Kosina <redacted>

bch_gc_thread() doesn't mark itself freezable, so calling try_to_freeze() 
in its context is just an expensive no-op.

Signed-off-by: Jiri Kosina <redacted>
---
 drivers/md/bcache/btree.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 22b9e34..eab505e 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -27,7 +27,6 @@
 
 #include <linux/slab.h>
 #include <linux/bitops.h>
-#include <linux/freezer.h>
 #include <linux/hash.h>
 #include <linux/kthread.h>
 #include <linux/prefetch.h>
@@ -1787,7 +1786,6 @@ again:
 
 		mutex_unlock(&c->bucket_lock);
 
-		try_to_freeze();
 		schedule();
 	}
 
-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help