Thread (14 messages) 14 messages, 3 authors, 2016-05-24

Re: [PATCH] bcache: bch_writeback_thread() is not freezable

From: Jiri Kosina <jikos@kernel.org>
Date: 2016-05-11 07:55:53
Also in: lkml

On Tue, 10 May 2016, Eric Wheeler wrote:
quoted
quoted
bch_writeback_thread() is calling try_to_freeze(), but that's just an 
expensive no-op given the fact that the thread is not marked freezable.

I/O helper kthreads, exactly such as the bcache writeback thread, actually 
shouldn't be freezable, because they are potentially necessary for 
finalizing the image write-out.

Signed-off-by: Jiri Kosina <redacted>
Let's send a friendly ping on these three patches after two weeks...
Maciej,

Were you able to get a backtrace?
While I'd definitely like to understand the issues in interaction between 
hibernation and bcache Maciej is supposedly seeing, this shouldn't hold 
the application of the three patches in this series, as they are just a 
cleanup that doesn't affect the behavior of the code in question.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help