Thread (7 messages) 7 messages, 3 authors, 2014-02-18

Re: New bcache compiler warning (was: Re: bcache: Minor fixes from kbuild robot)

From: Randy Dunlap <hidden>
Date: 2014-02-17 21:06:59
Also in: lkml

On 02/17/2014 01:00 PM, Geert Uytterhoeven wrote:
On Fri, Feb 14, 2014 at 8:04 PM, Linux Kernel Mailing List
[off-list ref] wrote:
quoted
   bcache: Minor fixes from kbuild robot
quoted
diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
index 4f6b594..3f74b4b 100644
--- a/drivers/md/bcache/bset.c
+++ b/drivers/md/bcache/bset.c
@@ -23,7 +23,7 @@ void bch_dump_bset(struct btree_keys *b, struct bset *i, unsigned set)
        for (k = i->start; k < bset_bkey_last(i); k = next) {
                next = bkey_next(k);

-               printk(KERN_ERR "block %u key %zi/%u: ", set,
+               printk(KERN_ERR "block %u key %li/%u: ", set,
                       (uint64_t *) k - i->d, i->keys);

                if (b->ops->key_dump)
On 32-bit (m68k):
drivers/md/bcache/bset.c: In function ‘bch_dump_bset’:
drivers/md/bcache/bset.c:27: warning: format ‘%li’ expects type ‘long
int’, but argument 3 has type ‘int’

What are you trying to print here? It looks a bit strange to me.
Technically, the difference between two pointers is of type ptrdiff_.
The kernel had

typedef __kernel_ptrdiff_t      ptrdiff_t;

and

#if __BITS_PER_LONG != 64
typedef unsigned int    __kernel_size_t;
typedef int             __kernel_ssize_t;
typedef int             __kernel_ptrdiff_t;
#else
typedef __kernel_ulong_t __kernel_size_t;
typedef __kernel_long_t __kernel_ssize_t;
typedef __kernel_long_t __kernel_ptrdiff_t;
#endif

So I'd expect "%zi" to be the right way, and a quick test compile on
32-bit (m68k)
and 64-bit (amd64) comfirms that. What was wrong with it?
The kernel supports 't' (%t) for ptrdiff_t (same as glibc),
so %ti should work (or %tu).

-- 
~Randy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help