Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix

From: Tejun Heo <hidden>
Date: 2012-10-19 20:34:28
Also in: dm-devel, lkml
Reply to: Kent Overstreet, 2012-10-15

On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote:

This adds a pointer to the bvec array to struct bio_integrity_payload,
instead of the bvecs always being inline; then the bvecs are allocated
with bvec_alloc_bs().

This is needed eventually for immutable bio vecs - immutable bvecs
aren't useful if we still have to copy them, hence the need for the
pointer. Less code is always nice too, though.

Also fix an amusing bug in bio_integrity_split() - struct bio_pair
doesn't have the integrity bvecs after the bio_integrity_payloads, so
there was a buffer overrun. The code was confusing pointers with arrays.

Ummm... patch description doesn't agree with the patch content?

-- 
tejun

Kent Overstreet · 2012-10-15
[PATCH v4 02/24] block: Refactor blk_update_request() · Kent Overstreet · 2012-10-15
[PATCH v4 01/24] block: Add bio_advance() · Kent Overstreet · 2012-10-15
[PATCH v4 07/24] block: Remove bi_idx references · Kent Overstreet · 2012-10-15
[PATCH v4 10/24] raid10: Use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v4 12/24] raid5: use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v4 15/24] pktcdvd: use bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v4 20/24] block: Convert some code to bio_for_each_segment_all() · Kent Overstreet · 2012-10-15
[PATCH v4 21/24] block: Add bio_alloc_pages() · Kent Overstreet · 2012-10-15
[PATCH v4 1/2] block: Reorder struct bio_set · Kent Overstreet · 2012-10-15
Re: [PATCH v4 1/2] block: Reorder struct bio_set · Tejun Heo · 2012-10-19
[PATCH v4 2/2] block: Convert integrity to bvec_alloc_bs() · Kent Overstreet · 2012-10-15
Re: [PATCH v4 2/2] block: Convert integrity to bvec_alloc_bs() · Vivek Goyal · 2012-10-19
[PATCH v2 04/26] md: Convert md_trim_bio() to use bio_advance() · Kent Overstreet · 2012-10-15
[PATCH v2 10/26] block: Add submit_bio_wait(), remove from md · Kent Overstreet · 2012-10-15
[PATCH v2 09/26] block: Remove some unnecessary bi_vcnt usage · Kent Overstreet · 2012-10-15
[PATCH v2 08/26] block: Remove bi_idx references · Kent Overstreet · 2012-10-15
[PATCH v2 15/26] block: Add bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v2 20/26] block: Add bio_for_each_segment_all() · Kent Overstreet · 2012-10-15
[PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Kent Overstreet · 2012-10-15
[PATCH v2 25/26] bio-integrity: Add explicit field for owner of bip_buf · Kent Overstreet · 2012-10-15
[PATCH v2 24/26] block: Add an explicit bio flag for bios that own their bvec · Kent Overstreet · 2012-10-15
[PATCH v2 26/26] block: Add BIO_SUBMITTED flag, kill BIO_CLONED · Kent Overstreet · 2012-10-15
[PATCH v2 23/26] raid1: use bio_alloc_pages() · Kent Overstreet · 2012-10-15
[PATCH v2 22/26] block: Add bio_alloc_pages() · Kent Overstreet · 2012-10-15
[PATCH v2 21/26] block: Convert some code to bio_for_each_segment_all() · Kent Overstreet · 2012-10-15
[PATCH v2 18/26] raid1: use bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v2 17/26] pktcdvd: Use bio_reset() in disabled code to kill bi_idx usage · Kent Overstreet · 2012-10-15
[PATCH v2 16/26] pktcdvd: use bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v2 14/26] raid1: Refactor narrow_write_error() to not use bi_idx · Kent Overstreet · 2012-10-15
[PATCH v2 13/26] raid5: use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v2 12/26] raid1: use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v2 11/26] raid10: Use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v2 07/26] block: Don't use bi_idx in bio_split() or require it to be 0 · Kent Overstreet · 2012-10-15
[PATCH v2 06/26] block: Use bio_sectors() more consistently · Kent Overstreet · 2012-10-15
[PATCH v2 05/26] block: Add bio_end() · Kent Overstreet · 2012-10-15
[PATCH v2 03/26] block: Refactor blk_update_request() · Kent Overstreet · 2012-10-15
[PATCH v2 02/26] block: Add bio_advance() · Kent Overstreet · 2012-10-15
[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Kent Overstreet · 2012-10-15
Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Tejun Heo · 2012-10-19
Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Tejun Heo · 2012-10-19
[PATCH v2 00/26] Prep work for immutable bio vecs · Kent Overstreet · 2012-10-15
[PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() · Kent Overstreet · 2012-10-15
Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() · Tejun Heo · 2012-10-19
Re: [PATCH v4 1/2] block: Fix a buffer overrun in bio_integrity_split() · Vivek Goyal · 2012-10-22
[PATCH v4 2/2] block: Avoid deadlocks with bio allocation by stacking drivers · Kent Overstreet · 2012-10-15
[PATCH v4 24/24] block: Add BIO_SUBMITTED flag, kill BIO_CLONED · Kent Overstreet · 2012-10-15
[PATCH v4 23/24] bio-integrity: Add explicit field for owner of bip_buf · Kent Overstreet · 2012-10-15
[PATCH v4 22/24] block: Add an explicit bio flag for bios that own their bvec · Kent Overstreet · 2012-10-15
[PATCH v4 19/24] block: Add bio_for_each_segment_all() · Kent Overstreet · 2012-10-15
[PATCH v4 18/24] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Kent Overstreet · 2012-10-15
[PATCH v4 17/24] raid1: use bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v4 16/24] pktcdvd: Use bio_reset() in disabled code to kill bi_idx usage · Kent Overstreet · 2012-10-15
[PATCH v4 14/24] block: Add bio_copy_data() · Kent Overstreet · 2012-10-15
[PATCH v4 13/24] raid1: Refactor narrow_write_error() to not use bi_idx · Kent Overstreet · 2012-10-15
[PATCH v4 11/24] raid1: use bio_reset() · Kent Overstreet · 2012-10-15
[PATCH v4 09/24] block: Add submit_bio_wait(), remove from md · Kent Overstreet · 2012-10-15
[PATCH v4 08/24] block: Remove some unnecessary bi_vcnt usage · Kent Overstreet · 2012-10-15
RE: [PATCH v4 08/24] block: Remove some unnecessary bi_vcnt usage · Reddy, Sreekanth · 2012-11-06
RE: [PATCH v4 08/24] block: Remove some unnecessary bi_vcnt usage · Reddy, Sreekanth · 2012-11-07
[PATCH v4 06/24] block: Change bio_split() to respect the current value of bi_idx · Kent Overstreet · 2012-10-15
[PATCH v4 05/24] block: Use bio_sectors() more consistently · Kent Overstreet · 2012-10-15
Re: [PATCH v4 05/24] block: Use bio_sectors() more consistently · Ed Cashin · 2012-10-16
[PATCH v4 04/24] block: Add bio_end_sector() · Kent Overstreet · 2012-10-15
[PATCH v4 03/24] md: Convert md_trim_bio() to use bio_advance() · Kent Overstreet · 2012-10-15
Tejun Heo · 2012-10-19
Mike Snitzer · 2012-10-19
View all 67 messages

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help