Thread (35 messages) 35 messages, 3 authors, 2012-10-11

Re: [PATCH 4/5] aio: vmap ringbuffer

From: Kent Overstreet <hidden>
Date: 2012-10-09 21:31:21
Also in: dm-devel, lkml

On Tue, Oct 09, 2012 at 11:29:49AM -0700, Zach Brown wrote:
On Mon, Oct 08, 2012 at 11:39:19PM -0700, Kent Overstreet wrote:
quoted
It simplifies a lot of stuff if the ringbuffer is contiguously mapped
into kernel space, and we can delete a lot of code - in particular, this
is useful for converting read_events() to cmpxchg.
1) I'm concerned that Our Favourite Database Benchmarkers will see an
effect of having more TLB pressure from that mapping.  kmap_atomic()
should be cheaper.  We'll need to measure the difference.
If it is measurable I'll take another stab at using memory from
__get_free_pages() for the ringbuffer. That really would be the ideal
solution.

The other reason I wanted to do this was for the aio attributes stuff -
for return values, I think the only sane way is for the return values to
go in the ringbuffer, which means records are no longer fixed size so
dealing with pages is even more of a pain.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help