Thread (68 messages) 68 messages, 7 authors, 2012-10-04

Re: [PATCH v3 05/26] md: Convert md_trim_bio() to use bio_advance()

From: Kent Overstreet <hidden>
Date: 2012-09-27 04:42:14
Also in: dm-devel, lkml

On Wed, Sep 26, 2012 at 10:38:27AM +1000, NeilBrown wrote:
On Mon, 24 Sep 2012 15:34:45 -0700 Kent Overstreet [off-list ref]
wrote:
quoted
Signed-off-by: Kent Overstreet <redacted>
CC: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
CC: NeilBrown <redacted>
---
 drivers/md/md.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 7a2b079..51ce48c 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -190,25 +190,16 @@ void md_trim_bio(struct bio *bio, int offset, int size)
 	struct bio_vec *bvec;
 	int sofar = 0;
 
-	size <<= 9;
 	if (offset == 0 && size == bio->bi_size)
 		return;
Safer to leave the "size <<= 9" where it is, otherwise that condition will
always fail.
Whoops, moving that certainly didn't make sense. Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help