Re: [PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec

[PATCH v2 00/26] Prep work for immutable bio vecs · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 03/26] block: Refactor blk_update_request() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 03/26] block: Refactor blk_update_request() · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 03/26] block: Refactor blk_update_request() · Kent Overstreet <hidden> · 2012-09-20
Re: [PATCH v2 03/26] block: Refactor blk_update_request() · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 03/26] block: Refactor blk_update_request() · Kent Overstreet <hidden> · 2012-09-20
[PATCH v2 07/26] block: Don't use bi_idx in bio_split() or require it to be 0 · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 07/26] block: Don't use bi_idx in bio_split() or require it to be 0 · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 07/26] block: Don't use bi_idx in bio_split() or require it to be 0 · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 06/26] block: Use bio_sectors() more consistently · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 06/26] block: Use bio_sectors() more consistently · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 06/26] block: Use bio_sectors() more consistently · Kent Overstreet <hidden> · 2012-09-20
[PATCH v2 15/26] block: Add bio_copy_data() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 15/26] block: Add bio_copy_data() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 15/26] block: Add bio_copy_data() · Kent Overstreet <hidden> · 2012-09-21
Re: [PATCH v2 15/26] block: Add bio_copy_data() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 15/26] block: Add bio_copy_data() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 15/26] block: Add bio_copy_data() · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 16/26] pktcdvd: use bio_copy_data() · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 26/26] block: Add BIO_SUBMITTED flag, kill BIO_CLONED · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 25/26] bio-integrity: Add explicit field for owner of bip_buf · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 24/26] block: Add an explicit bio flag for bios that own their bvec · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 23/26] raid1: use bio_alloc_pages() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 23/26] raid1: use bio_alloc_pages() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 23/26] raid1: use bio_alloc_pages() · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 22/26] block: Add bio_alloc_pages() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 22/26] block: Add bio_alloc_pages() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 22/26] block: Add bio_alloc_pages() · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 21/26] block: Convert some code to bio_for_each_segment_all() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 21/26] block: Convert some code to bio_for_each_segment_all() · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 21/26] block: Convert some code to bio_for_each_segment_all() · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 20/26] block: Add bio_for_each_segment_all() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 20/26] block: Add bio_for_each_segment_all() · Tejun Heo <tj@kernel.org> · 2012-09-21
[PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Kent Overstreet <hidden> · 2012-09-21
Re: [PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Tejun Heo <tj@kernel.org> · 2012-09-21
Re: [PATCH v2 19/26] bounce: Refactor __blk_queue_bounce to not use bi_io_vec · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 18/26] raid1: use bio_copy_data() · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 17/26] pktcdvd: Use bio_reset() in disabled code to kill bi_idx usage · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 14/26] raid1: Refactor narrow_write_error() to not use bi_idx · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 13/26] raid5: use bio_reset() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 13/26] raid5: use bio_reset() · NeilBrown <hidden> · 2012-09-11
Re: [PATCH v2 13/26] raid5: use bio_reset() · Kent Overstreet <hidden> · 2012-09-11
[PATCH v2 12/26] raid1: use bio_reset() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 12/26] raid1: use bio_reset() · NeilBrown <hidden> · 2012-09-11
Re: [PATCH v2 12/26] raid1: use bio_reset() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 12/26] raid1: use bio_reset() · NeilBrown <hidden> · 2012-09-11
[PATCH v2 11/26] raid10: Use bio_reset() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 11/26] raid10: Use bio_reset() · Tejun Heo <tj@kernel.org> · 2012-09-20
[PATCH v2 10/26] block: Add submit_bio_wait(), remove from md · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 09/26] block: Remove some unnecessary bi_vcnt usage · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 09/26] block: Remove some unnecessary bi_vcnt usage · Tejun Heo <tj@kernel.org> · 2012-09-20
[PATCH v2 08/26] block: Remove bi_idx references · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 08/26] block: Remove bi_idx references · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 08/26] block: Remove bi_idx references · Kent Overstreet <hidden> · 2012-09-21
[PATCH v2 05/26] block: Add bio_end() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 05/26] block: Add bio_end() · Steven Whitehouse <hidden> · 2012-09-17
Re: [PATCH v2 05/26] block: Add bio_end() · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 05/26] block: Add bio_end() · Kent Overstreet <hidden> · 2012-09-20
[PATCH v2 04/26] md: Convert md_trim_bio() to use bio_advance() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 04/26] md: Convert md_trim_bio() to use bio_advance() · Tejun Heo <tj@kernel.org> · 2012-09-20
[PATCH v2 02/26] block: Add bio_advance() · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 02/26] block: Add bio_advance() · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 02/26] block: Add bio_advance() · Kent Overstreet <hidden> · 2012-09-20
Re: [PATCH v2 02/26] block: Add bio_advance() · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 02/26] block: Add bio_advance() · Kent Overstreet <hidden> · 2012-09-20
[PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Kent Overstreet <hidden> · 2012-09-11
Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Vivek Goyal <vgoyal@redhat.com> · 2012-09-11
Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Kent Overstreet <hidden> · 2012-09-11
Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Kent Overstreet <hidden> · 2012-09-11
Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix · Tejun Heo <tj@kernel.org> · 2012-09-20
Re: [PATCH v2 00/26] Prep work for immutable bio vecs · NeilBrown <hidden> · 2012-09-11
Re: [PATCH v2 00/26] Prep work for immutable bio vecs · Tejun Heo <tj@kernel.org> · 2012-09-20

From: Tejun Heo <hidden>
Date: 2012-09-21 00:27:16
Also in: dm-devel, lkml

On Mon, Sep 10, 2012 at 05:22:30PM -0700, Kent Overstreet wrote:

A bunch of what __blk_queue_bounce() was doing was problematic for the
immutable bvec work; this cleans that up and the code is quite a bit
smaller, too.

The __bio_for_each_segment() in copy_to_high_bio_irq() was changed
because that one's looping over the original bio, not the bounce bio -
since the bounce code doesn't own that bio the __ version wasn't
correct.

Also, I can't understand the above at all.  I can think why it
wouldn't be necessary but why is it wrong because bounce code doesn't
own it?

-- 
tejun

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help