Re: [PATCH v2 10/26] block: Add submit_bio_wait(), remove from md

From
Kent Overstreet <hidden>
Date
2012-09-21 00:12:53
Also in
dm-devel, lkml
Reply to
Tejun Heo, 2012-09-20
On Thu, Sep 20, 2012 at 04:56:43PM -0700, Tejun Heo wrote:
On Mon, Sep 10, 2012 at 05:22:21PM -0700, Kent Overstreet wrote:
quoted
Random cleanup - this code was duplicated and it's not really specific
to md.

Also added the ability to return the actual error code.

Signed-off-by: Kent Overstreet <redacted>
CC: Jens Axboe <redacted>
CC: NeilBrown <redacted>
Acked-by: Tejun Heo <redacted>
quoted
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -249,6 +249,7 @@ extern void bio_endio(struct bio *, int);
 struct request_queue;
 extern int bio_phys_segments(struct request_queue *, struct bio *);
 
+extern int submit_bio_wait(int rw, struct bio *bio);
 void bio_advance(struct bio *, unsigned);
Heh, this is one of the reasons why I don't like extern on function
prototypes.  It's not necessary and people end up jumping between the
two forms.  :(
Yeah, I dislike it too but I was trying to follow the style in that file
- I did fix bio_advance() a few minutes ago.
Thread (76 messages) 76 messages, 5 authors, last reply 2012-09-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help