Re: [PATCH v7 5/9] block: Kill bi_destructor

On Tue, Aug 28, 2012 at 01:36:13PM -0700, Tejun Heo wrote:

On Tue, Aug 28, 2012 at 10:37:32AM -0700, Kent Overstreet wrote:

quoted

@@ -385,7 +386,7 @@ struct bio *bio_kmalloc(gfp_t gfp_mask, unsigned int nr_iovecs)
 	bio->bi_flags |= BIO_POOL_NONE << BIO_POOL_OFFSET;
 	bio->bi_max_vecs = nr_iovecs;
 	bio->bi_io_vec = bio->bi_inline_vecs;
-	bio->bi_destructor = bio_kmalloc_destructor;
+	bio->bi_pool = NULL;

Doesn't bio_init() already memset the whole thing?

Yes it does, holdover from BIO_KMALLOC_POOL. Dropping it.