Re: [PATCH v4 09/12] block: Rework bio_pair_split()
From: Boaz Harrosh <hidden>
Date: 2012-07-25 12:04:06
Also in:
dm-devel, lkml
On 07/24/2012 11:11 PM, Kent Overstreet wrote:
This changes bio_pair_split() to use the new bio_split() underneath, which gets rid of the single page bio limitation. The various callers are fixed up for the slightly different struct bio_pair, and to remove the unnecessary checks. Signed-off-by: Kent Overstreet <redacted>
<snip>
+ +extern struct bio *bio_split(struct bio *bio, int sectors, + gfp_t gfp, struct bio_set *bs);
nit: Just for taking pride in my work, I'd move this extern declaration to the previous patch that actually introduces it. Cheers Boaz
quoted hunk ↗ jump to hunk
extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors); extern void bio_pair_release(struct bio_pair *dbio);@@ -512,7 +514,6 @@ extern int bio_integrity_prep(struct bio *); extern void bio_integrity_endio(struct bio *, int); extern void bio_integrity_advance(struct bio *, unsigned int); extern void bio_integrity_trim(struct bio *, unsigned int, unsigned int); -extern void bio_integrity_split(struct bio *, struct bio_pair *, int); extern int bio_integrity_clone(struct bio *, struct bio *, gfp_t, struct bio_set *); extern int bioset_integrity_create(struct bio_set *, int); extern void bioset_integrity_free(struct bio_set *);@@ -556,12 +557,6 @@ static inline int bio_integrity_clone(struct bio *bio, struct bio *bio_src, return 0; } -static inline void bio_integrity_split(struct bio *bio, struct bio_pair *bp, - int sectors) -{ - return; -} - static inline void bio_integrity_advance(struct bio *bio, unsigned int bytes_done) {