Thread (1 message) 1 message, 1 author, 2012-05-29

Re: [PATCH v3 05/16] block: Kill bi_destructor

From: Tejun Heo <hidden>
Date: 2012-05-29 02:20:25
Also in: dm-devel, linux-fsdevel, lkml

Hello, Kent.

On Mon, May 28, 2012 at 10:10:42PM -0400, Kent Overstreet wrote:
Heh. Well, in my view deleting stuff is good by default, and if you can
delete things without user visible effects and without making the code
more complicated... 

So I guess given the simplicity of this particular patch in the series
I'm not sure what there is to justify here. Any suggestions on what
would make sense to put in...?
So, what I would prefer to see is the justification of the whole
changes somewhere in the patch stream, so that patches can do,n

patch 1: update X to not use bi_destructor which will soon be removed.
patch 2: ditto for Y
...
patch N: bi_destructor is stupid because blah blah and after preceding
         changes is no longer used.  Kill it.

so that when one sees a patch in the series and wonders why the change
is being made, [s]he can follow the patch stream and understand.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help