Re: [PATCH v2 08/14] block: Kill bi_destructor

On 05/24/2012 10:52 PM, Vivek Goyal wrote:

In fact I am not even sure that for one driver we should introduce
bio_reset() in generic block layer. So to me we should get rid of bio_reset()
and let all the gory details remain in driver.

I disagree. The kind of trick we do where up to BIO_RESET_BYTES
the struct is memset **must** stay at header, very close to the
structure.

I would though make bio_reset() inline at header, it's a single
memset. Even the memset is inlined by the compiler.

Thanks
Vivek

Thanks
Boaz